Skip to content

Avoid loading lineitem unnecessarily#16587

Merged
findepi merged 2 commits intomasterfrom
findepi/avoid-loading-unnecessary-test-tables-fa282e
Mar 16, 2023
Merged

Avoid loading lineitem unnecessarily#16587
findepi merged 2 commits intomasterfrom
findepi/avoid-loading-unnecessary-test-tables-fa282e

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Mar 16, 2023

No description provided.

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Mar 16, 2023
@findepi findepi requested review from alexjo2144 and ebyhr March 16, 2023 12:16
@cla-bot cla-bot Bot added the cla-signed label Mar 16, 2023
@github-actions github-actions Bot added the iceberg Iceberg connector label Mar 16, 2023
alexjo2144
alexjo2144 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was silly of me, thanks for cleaning it up.

@findepi findepi force-pushed the findepi/avoid-loading-unnecessary-test-tables-fa282e branch from 05f154a to f36bcac Compare March 16, 2023 15:09
@findepi findepi mentioned this pull request Mar 16, 2023
Merged
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Mar 16, 2023

Only PTs remaining and these are not affected. Will rebase to resolve conflict and merge.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Mar 16, 2023

@nineinchnick would it be possible to skip Iceberg PTs when only Iceberg integration tests are changed, not the connector production code?

@findepi findepi force-pushed the findepi/avoid-loading-unnecessary-test-tables-fa282e branch from 2d0a156 to 6b2aaaa Compare March 16, 2023 21:38
@findepi findepi merged commit 3e08039 into master Mar 16, 2023
@findepi findepi deleted the findepi/avoid-loading-unnecessary-test-tables-fa282e branch March 16, 2023 21:38
@nineinchnick
Copy link
Copy Markdown
Member

nineinchnick commented Mar 16, 2023

@nineinchnick would it be possible to skip Iceberg PTs when only Iceberg integration tests are changed, not the connector production code?

Not right now. To make product tests conditional, we rely on the list of impacted models produced by GIB. GIB doesn't distinguish changes in tests from regular code. We'd have to find another way to identify impacted modules, or come up with a reason for GIB to make the distinction and possibly contribute that change to it.

@github-actions github-actions Bot added this to the 411 milestone Mar 16, 2023
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

+1 more reviewer

@alexjo2144 alexjo2144 alexjo2144 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed iceberg Iceberg connector no-release-notes This pull request does not require release notes entry test

Milestone

411

Development

Successfully merging this pull request may close these issues.

4 participants

@findepi @nineinchnick @ebyhr @alexjo2144